YaruTitleBar: consider active by default #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of requiring an explicit `isActive: true`, check that it's not explicitly `false`. In other words, consider `null` active, too. This helps to render dialogs correctly when they become visible. It might take a noticeable amount of time to fetch the information over the platform channel.
|
The issue is barely visible in this screencast. Look at the close button very closely when navigating forward. It turns disabled for a moment. Screencast.from.2023-01-10.17-52-52.webm |
Feichtmeier
approved these changes
Jan 11, 2023
|
oh, you have forgotten the goldens 🏅 😄 @jpnurmi |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring an explicit
isActive: true, check that it's not explicitlyfalse. In other words, considernullactive, too. This helps to render dialogs correctly when they become visible. It might take a noticeable amount of time to fetch the information over the platform channel.