Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YaruTitleBarStyle (hidden, background, normal) #510

Merged
merged 4 commits into from Jan 13, 2023
Merged

Add YaruTitleBarStyle (hidden, background, normal) #510

merged 4 commits into from Jan 13, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jan 12, 2023

This allows creating "placeholder" title bars without any buttons but with full functionality i.e. double- and right-click handling.

appBar: const YaruWindowTitleBar(
  title: Text('Example'),
  style: YaruTitleBarStyle.background,
)

Fixes: #508

This allows creating "placeholder" title bars without any buttons but
with full functionality e.g. double and right click handling.

Fixes: #508
@jpnurmi jpnurmi marked this pull request as draft January 12, 2023 22:12
@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 12, 2023

Hold on, there's still a little puzzle to solve! We need to find a way to dynamically change it from normal to background depending on the MD layout. 😰

Screencast.from.2023-01-12.23-12-09.webm

@Feichtmeier
Copy link
Member

Yep was about to post that it did not work as described when using your fork and this branch with pub upgrade :)
Alright no hurry cu tomorrow 👋 🌃

@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 12, 2023

Landscape mode is 👌

Screencast.from.2023-01-12.23-17-32.webm

@jpnurmi jpnurmi marked this pull request as ready for review January 13, 2023 07:06
@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 13, 2023

Ok, I have made the style themable in preparation to be able to specify the desired default for MD. I will create a separate PR for the MD changes but here's a sneak preview:

Screencast.from.2023-01-13.08-15-45.webm

@jpnurmi

This comment was marked as outdated.

@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 13, 2023

@Feichtmeier Are the names "hidden", "background", and "normal" sensible? I don't really like the name "background" but I'm having a hard time coming up with a nicer alternative.

  • "empty" (it's not really empty because it can have title/leading/trailing)
  • "plain"
  • "minimal"
  • "buttonless" (certainly describes what it does but sounds weird)

@Feichtmeier
Copy link
Member

@jpnurmi how about undecorated for background?

@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 13, 2023

@Feichtmeier thanks, not bad! :)

@Feichtmeier
Copy link
Member

I just know this word from our gnome experience 🦶 😄 🤷

@Feichtmeier
Copy link
Member

Tried and works 💪 , thank you 👍

2023-01-13.09-07-10.mp4

@Feichtmeier Feichtmeier merged commit 2bf3ba7 into ubuntu:main Jan 13, 2023
@jpnurmi jpnurmi deleted the title-bar-style branch January 13, 2023 09:24
@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 13, 2023

Impressive how you massaged it through the CI. My builds are still failing everywhere because of the Azure issues.

@Feichtmeier
Copy link
Member

@jpnurmi jpnurmi mentioned this pull request Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window title bar: full control over double-click
2 participants