New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YaruTitleBarStyle (hidden, background, normal) #510
Conversation
This allows creating "placeholder" title bars without any buttons but with full functionality e.g. double and right click handling. Fixes: #508
Hold on, there's still a little puzzle to solve! We need to find a way to dynamically change it from normal to background depending on the MD layout. 😰 Screencast.from.2023-01-12.23-12-09.webm |
Yep was about to post that it did not work as described when using your fork and this branch with pub upgrade :) |
Landscape mode is 👌 Screencast.from.2023-01-12.23-17-32.webm |
Ok, I have made the style themable in preparation to be able to specify the desired default for MD. I will create a separate PR for the MD changes but here's a sneak preview: Screencast.from.2023-01-13.08-15-45.webm |
This comment was marked as outdated.
This comment was marked as outdated.
@Feichtmeier Are the names "hidden", "background", and "normal" sensible? I don't really like the name "background" but I'm having a hard time coming up with a nicer alternative.
|
@jpnurmi how about undecorated for background? |
@Feichtmeier thanks, not bad! :) |
I just know this word from our gnome experience 🦶 😄 🤷 |
Tried and works 💪 , thank you 👍 2023-01-13.09-07-10.mp4 |
Impressive how you massaged it through the CI. My builds are still failing everywhere because of the Azure issues. |
This allows creating "placeholder" title bars without any buttons but with full functionality i.e. double- and right-click handling.
Fixes: #508