Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example: use CSD with yaruwindowtitlebar if not web #513

Closed
wants to merge 1 commit into from
Closed

Example: use CSD with yaruwindowtitlebar if not web #513

wants to merge 1 commit into from

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Jan 13, 2023 •
edited

Example

Desktop
grafik

Web
grafik

Pull request checklist

  • This PR does not introduce visual changes, or
    • I ran flutter test --update-goldens and committed the changes if there were any, or
    • I added before/after/light/dark screenshots if the visual changes I made were not covered by golden tests.
      Before After
      Light
      Dark

@jpnurmi
Copy link
Member

jpnurmi commented Jan 13, 2023 •
edited

This PR will adjust things so that you can simply replace AppBar with YaruWindowTitleBar. It will default to the "undecorated" style on web and doesn't react to the usual window title bar interaction so it should work as you'd expect on web. 😉

@Feichtmeier Feichtmeier mentioned this pull request Jan 14, 2023
Merged
@jpnurmi
Copy link
Member

jpnurmi commented Jan 14, 2023

Hold on, the navi rail layout is missing window title bar altogether. :)

@Feichtmeier Feichtmeier marked this pull request as draft January 14, 2023 08:30
@jpnurmi jpnurmi mentioned this pull request Jan 14, 2023
Merged
Feichtmeier pushed a commit that referenced this pull request Jan 14, 2023
@jpnurmi
Example: make better use of YaruWindowTitleBar (#521)
9a00484 
* Example: make better use of YaruWindowTitleBar

Supercedes #513

* NavigationPage: use YaruDetailPage + YaruWindowTitleBar

* Filter out NavigationPage from the navi-rail layout
@Jupi007 Jupi007 deleted the example_yarutitlebar_if_not_web branch February 24, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnurmi jpnurmi Awaiting requested review from jpnurmi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Feichtmeier @jpnurmi