Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaffold to yaru-master-detail page #525

Merged

Conversation

whiskeyPeak
Copy link
Contributor

@whiskeyPeak whiskeyPeak commented Jan 15, 2023

Adds a scaffold to fix indefinite issues with flutter showing the root GTK window and therefore not applying the correct theme. This is a regression from main.

maybe fixes #522

Pull request checklist

  • This PR does not introduce visual changes, or
    • I ran flutter test --update-goldens and committed the changes if there were any, or
    • I added before/after/light/dark screenshots if the visual changes I made were not covered by golden tests.
      Before After
      Light Screenshot from 2023-01-15 01-55-09 Screenshot from 2023-01-15 01-56-40
      Dark Screenshot from 2023-01-15 01-58-47 Screenshot from 2023-01-15 01-58-06

Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

We need to take a closer look at how and where we use Scaffolds and if we could replace some of them with simpler structures but let's take it separately.

@Feichtmeier Feichtmeier merged commit c5cc3fb into ubuntu:main Jan 15, 2023
@jpnurmi jpnurmi mentioned this pull request Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrongly colored separator
3 participants