Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landscape: remove separator fix for web, not needed anymore #529

Merged
merged 1 commit into from Jan 15, 2023

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Jan 15, 2023

since yaru master details now has a scaffold we dont need this anymore

grafik

Pull request checklist

  • This PR does not introduce visual changes, or
    • I ran flutter test --update-goldens and committed the changes if there were any, or
    • I added before/after/light/dark screenshots if the visual changes I made were not covered by golden tests.
      Before After
      Light
      Dark

jpnurmi
jpnurmi previously approved these changes Jan 15, 2023
@jpnurmi jpnurmi dismissed their stale review January 15, 2023 19:32

the goldens should not change?

since yaru master details now has a scaffold we dont need this anymore
@Feichtmeier
Copy link
Member Author

sorry was again outdated yaru on this other computer 🐈

@Feichtmeier Feichtmeier merged commit 64b0291 into main Jan 15, 2023
@Feichtmeier Feichtmeier deleted the remove_fix_for_web branch January 15, 2023 19:59
@jpnurmi jpnurmi mentioned this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants