Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of deprecated members (beta channel) #551

Merged
merged 1 commit into from Jan 20, 2023
Merged

Fix use of deprecated members (beta channel) #551

merged 1 commit into from Jan 20, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jan 20, 2023 •
edited 

Flutter 3.7.0-1.4.pre • channel beta • https://github.com/flutter/flutter.git
Framework • revision 686fe913dc (9 days ago) • 2023-01-10 16:14:01 -0800
Engine • revision ac5c83dd5f
Tools • Dart 2.19.0 (build 2.19.0-444.4.beta) • DevTools 2.20.0

jpnurmi
jpnurmi commented Jan 20, 2023
View reviewed changes
example/lib/code_snippet_button.dart
@@ -80,7 +80,7 @@ class _CodeDialog extends StatelessWidget {
children: [
YaruAnimatedNoNetworkIcon(
size: 200,
color: Theme.of(context).errorColor,
color: Theme.of(context).colorScheme.error,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

'errorColor' is deprecated and shouldn't be used. Use colorScheme.error instead. This feature was deprecated after v3.3.0-0.5.pre.

lib/src/pages/yaru_tile.dart
final theme = Theme.of(context);
switch (style) {
case YaruTileStyle.normal:
return theme.textTheme.bodyText1!;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

'bodyText1' is deprecated and shouldn't be used. Use bodyLarge instead. This feature was deprecated after v3.1.0-0.0.pre.

@Feichtmeier
Copy link
Member

🙏👍

@Feichtmeier Feichtmeier merged commit 17e7289 into ubuntu:main Jan 20, 2023
@jpnurmi jpnurmi deleted the deprecated branch January 20, 2023 07:44
@jpnurmi jpnurmi mentioned this pull request Jan 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpnurmi @Feichtmeier