Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: fix the settings bottom bar look sensible with Flutter beta #552

Merged
merged 1 commit into from Jan 20, 2023
Merged

Example: fix the settings bottom bar look sensible with Flutter beta #552

merged 1 commit into from Jan 20, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jan 20, 2023

M3 bottom bar has gained default padding and a height of 80px on the beta channel. We can switch to a simpler structure to avoid having to customize it in the example. All we need is a tile with an opaque background and a little padding around. :)

Before After
Stable image image
Beta image image

NOTE: The white divider is a separate issue discussed at:

@jpnurmi jpnurmi requested a review from Jupi007 January 20, 2023 09:35
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM 👍

Thanks :)

@Jupi007 Jupi007 merged commit 8be7609 into ubuntu:main Jan 20, 2023
@jpnurmi jpnurmi deleted the example-bottom-bar branch January 20, 2023 10:09
@jpnurmi jpnurmi mentioned this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants