Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YaruDetailPage: allow specifying the hero tag #553

Merged
merged 4 commits into from
Jan 20, 2023
Merged

YaruDetailPage: allow specifying the hero tag #553

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac5e8c4
YaruDetailPage: allow specifying the hero tag
jpnurmi Jan 20, 2023
36bbabe
Rename the tag type. A bit shorter name looks nicer
jpnurmi Jan 20, 2023
10ba7f6
Simplify the hero tag to a constant string
jpnurmi Jan 20, 2023
6636d2a
It's not a class name any more :P
jpnurmi Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions lib/src/layouts/yaru_detail_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import 'package:flutter/material.dart';

const _kYaruDetailPageHeroTag = '<YaruDetailPageHeroTag>';

/// Provides the recommended layout for [YaruMasterDetailPage.pageBuilder].
///
/// This widget is similar to [Scaffold] with the exception that it wraps the
Expand All @@ -19,6 +21,7 @@ class YaruDetailPage extends StatelessWidget {
this.backgroundColor,
this.extendBody = false,
this.extendBodyBehindAppBar = false,
this.heroTag = _kYaruDetailPageHeroTag,
});

/// See [Scaffold.extendBody].
Expand Down Expand Up @@ -57,13 +60,23 @@ class YaruDetailPage extends StatelessWidget {
/// See [Scaffold.bottomSheet].
final Widget? bottomSheet;

/// The tag to use for the [Hero] wrapping the [appBar].
///
/// By default, a unique tag is used to ensure that the [appBar] stays in
/// place during page transitions. If set to `null`, no [Hero] will be used.
final Object? heroTag;

PreferredSizeWidget? _buildAppBar(BuildContext context) {
if (appBar == null) return null;
if (appBar == null ||
heroTag == null ||
context.findAncestorWidgetOfExactType<Hero>() != null) {
return appBar;
}

return PreferredSize(
preferredSize: appBar!.preferredSize,
child: Hero(
tag: '<YaruDetailPage Hero tag - $appBar>',
tag: heroTag!,
child: appBar!,
),
);
Expand Down