YaruTitleBar: allow specifying the hero tag

[jpnurmi]

The YaruTitleBar counterpart of #553.

Close: #549

[Jupi007]

LGFM 👍

I suppose that the toString method of the object passed to _YaruTitleBarHeroTag.id() is always properly implemented.

[jpnurmi]

In our case, it becomes "<_YaruDetailPageHeroTag YaruWindowTitleBar>" so it reads like "the detail page's hero tag for the app bar". We need the same tag for both title bars on the page transitioning in and out to achieve the effect that it stays in place. With custom hero tags you can either disable the whole thing if it's not suitable for your app structure, or you can adapt it to more complex scenarios e.g. only applying the effect when transitioning between certain pages.

[Jupi007]

Okay, thanks for the explanation :)
It is fine so, can I merge?

[jpnurmi]

Now that I think of it, the dynamic hero-tag formatting is pointless. We could just as well have a constant string?

[Jupi007]

As far as I understood, a constant would be enough, indeed :)

[jpnurmi]

Yeah, seems to work fine. What was I even thinking 🤦‍♂️

[jpnurmi]

how many attempts do i need to create a string constant