Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goldens with Flutter 3.7.0 & latest yaru #564

Merged
merged 13 commits into from Jan 26, 2023
Merged

Update goldens with Flutter 3.7.0 & latest yaru #564

merged 13 commits into from Jan 26, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jan 25, 2023

No description provided.

Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - interestingly some small text have a better contrast now, which was band aid fixed in software often

@jpnurmi jpnurmi marked this pull request as draft January 25, 2023 08:09
@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 25, 2023

Looks like we should take care of yaru.dart first, because this one adds brown popup menus and white separators...

@Jupi007
Copy link
Member

Jupi007 commented Jan 26, 2023

Wtf, why does our own togglables are affected.
I remember that they only use the accent color 🤔

@jpnurmi jpnurmi changed the title Update goldens with Flutter 3.7.0 Update goldens with Flutter 3.7.0 & latest yaru Jan 26, 2023
@jpnurmi jpnurmi marked this pull request as ready for review January 26, 2023 16:20
@Feichtmeier
Copy link
Member

too many files I need to check out locally but first I need to update my flutter installation 🤞 to 3.7.0

Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find any visual regressions 👍

@Feichtmeier Feichtmeier merged commit ebb39b8 into ubuntu:main Jan 26, 2023
@jpnurmi jpnurmi deleted the goldens branch January 26, 2023 16:56
@jpnurmi jpnurmi mentioned this pull request Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants