Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent YaruTitleBar from reseting input focus #566

Merged
merged 1 commit into from Jan 26, 2023
Merged

Prevent YaruTitleBar from reseting input focus #566

merged 1 commit into from Jan 26, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jan 26, 2023

TextFieldTapRegion was introduced in Flutter 3.7.0 to solve the problem that clicking anywhere outside a TextField would reset input focus.

Before

Screencast.from.2023-01-26.22-09-34.webm

After

Screencast.from.2023-01-26.22-07-55.webm

Fixes: #550

@Feichtmeier
Copy link
Member

nice!

(offtopic: is this a 4k screen with 200% scaling?)

@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 26, 2023

(offtopic: is this a 4k screen with 200% scaling?)

yeah

@Feichtmeier
Copy link
Member

look @madsrh ! 4k screen with 200% scaling! ☝️

@Feichtmeier Feichtmeier merged commit 4aedb0e into ubuntu:main Jan 26, 2023
@jpnurmi jpnurmi deleted the title-bar-focus branch January 26, 2023 21:20
@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 26, 2023

It's a 13" laptop screen :)

@jpnurmi jpnurmi mentioned this pull request Jan 26, 2023
@Feichtmeier
Copy link
Member

yeah :) just joking a little because mads loves to create issues with ubuntu running on a 4k-5k screen with 100% scaling and he then creates weird window sizes like 3500x200 at 100% and says we need to change the layout for this 😋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title bar press resets input focus
2 participants