Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: YaruBanners bg color with upgrading yaru to 0.5.1 #575

Merged
merged 2 commits into from Jan 30, 2023
Merged

Fix: YaruBanners bg color with upgrading yaru to 0.5.1 #575

merged 2 commits into from Jan 30, 2023

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Jan 30, 2023 •
edited

grafik

Fixes #574

Pull request checklist

  • This PR does not introduce visual changes, or
    • I ran flutter test --update-goldens and committed the changes if there were any, or
    • I added before/after/light/dark screenshots if the visual changes I made were not covered by golden tests.
      Before After
      Light
      Dark

@Feichtmeier Feichtmeier changed the title Yarubanners got the wrong colour with yaru 0.5.0 Fix: YaruBanners bg color with upgrading yaru to 0.5.1 Jan 30, 2023
jpnurmi
jpnurmi approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Feichtmeier Feichtmeier merged commit 035bde0 into main Jan 30, 2023
@Feichtmeier Feichtmeier deleted the Feichtmeier/issue574 branch January 30, 2023 11:58
@Feichtmeier Feichtmeier mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnurmi jpnurmi jpnurmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yarubanners got the wrong colour with yaru 0.5.0
2 participants
@Feichtmeier @jpnurmi