Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add themes and various enhancements to togglables #613

Merged
merged 4 commits into from Feb 11, 2023
Merged

Add themes and various enhancements to togglables #613

merged 4 commits into from Feb 11, 2023

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Feb 11, 2023

  • Add checkbox, radio and switch themes ;
  • Rename some internal vars (hover -> hovered) ;
  • Remove design related properties from YaruTogglable ;
  • Fix antialiasing (see goldens), caused by coloured border ;
  • Add more customization option (border in all states, bordered switch...).

Fixes #612

Pull request checklist

  • I ran flutter test --update-goldens and committed the changes.

@Jupi007
Add themes and various enhancements to togglables
66c6c8f 
- Add checkbox, radio and switch themes ;
- Rename some internal vars (hover -> hovered) ;
- Remove design related properties from YaruTogglable ;
- Fix antialiasing (see goldens), caused by coloured border ;
- Add more customization option (border in all states, bordered switch...).

Fixes ubuntu#612
jpnurmi
jpnurmi reviewed Feb 11, 2023
View reviewed changes
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the const and naming police strikes again!

lib/src/widgets/yaru_checkbox.dart Outdated Show resolved Hide resolved
lib/src/widgets/yaru_radio.dart Outdated Show resolved Hide resolved
lib/src/widgets/yaru_switch.dart Outdated Show resolved Hide resolved
lib/src/widgets/yaru_switch_theme.dart Outdated Show resolved Hide resolved
lib/src/widgets/yaru_radio_theme.dart Show resolved Hide resolved
@Jupi007 Jupi007 requested a review from jpnurmi February 11, 2023 16:36
jpnurmi
jpnurmi approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

@Jupi007 Jupi007 merged commit e228f2a into ubuntu:main Feb 11, 2023
@Jupi007 Jupi007 deleted the Jupi007/issue612 branch February 11, 2023 17:17
@Jupi007
Copy link
Member Author

Jupi007 commented Feb 11, 2023

Thanks a lot for the review @jpnurmi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnurmi jpnurmi jpnurmi approved these changes

@Feichtmeier Feichtmeier Awaiting requested review from Feichtmeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add togglable themes
2 participants
@Jupi007 @jpnurmi