New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YaruPageIndicator: add custom scale parameters #624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that provide a way to customize dot size and spacing is a great idea!
But the way I implemented the current spacing was preventing layout overflow, while this PR doesn't provide any kind of security:
Peek.22-02-2023.13-25.mp4
@d-loose Can you implement a way to avoid overflow?
Also it would be nice that your new properties could not be factors, but real size:
final double dotSize = 12.0;
final double dotSpacingTarget; // target, because it can be stretched cause to the overflow guard
It is more intuitive in that way, and so we don't hide those parameters with some obscure internal stuff.
As a user, I'd rather specify the desired size and spacing than a factor because I don't know what the factor applies to :) |
also make sure vertical constraints are respected :)
Thanks! Screencast.from.2023-02-22.13-51-39.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't actually test it, but if you ensure me there's no more vertical overflow, then LGFM 🙂 👍
I can :) |
Allows to customize the size and spacing of
YaruPageIndicator
's dots:Screencast.from.2023-02-22.12-48-53.webm
Fix #622
Pull request checklist
flutter test --update-goldens
and committed the changes if there were any, or