Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop YaruSwitch.checkmarkColor earlier (2.2.0) #629

Merged
merged 2 commits into from Feb 24, 2023
Merged

Drop YaruSwitch.checkmarkColor earlier (2.2.0) #629

merged 2 commits into from Feb 24, 2023

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Feb 24, 2023

I also added a todo comment so we have an info row in vs code problems tab.

Fixes #627

Pull request checklist

  • This PR does not introduce visual changes

@Jupi007 Jupi007 requested a review from jpnurmi February 24, 2023 09:45
@Jupi007
Copy link
Member Author

Jupi007 commented Feb 24, 2023

I'll update goldens in a separate PR.

jpnurmi
jpnurmi approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Jupi007
Copy link
Member Author

Jupi007 commented Feb 24, 2023

@jpnurmi I'd like to merge #630, before merging this PR. So everything can be green :)

@Jupi007 Jupi007 merged commit e5c83ea into ubuntu:main Feb 24, 2023
@Jupi007 Jupi007 deleted the Jupi007/issue627 branch February 24, 2023 10:06
@jpnurmi jpnurmi mentioned this pull request Mar 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnurmi jpnurmi jpnurmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop YaruSwitch.checkmarkColor earlier
2 participants
@Jupi007 @jpnurmi