Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YaruPortraitLayout: add missing hero controller #643

Merged
merged 1 commit into from Mar 5, 2023
Merged

YaruPortraitLayout: add missing hero controller #643

merged 1 commit into from Mar 5, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Feb 26, 2023

It should also have one, just like YaruLandscapeLayout and YaruNavigationPage do.

@jpnurmi
YaruPortraitLayout: add missing hero controller
a6787fa 
It should also have one, just like YaruLandscapeLayout and
YaruNavigationPage do.
@jpnurmi jpnurmi requested a review from Jupi007 March 5, 2023 11:38
@Jupi007
Copy link
Member

Jupi007 commented Mar 5, 2023

I suppose this is a patch?
Because so you need to target the release branch 😉

@jpnurmi jpnurmi changed the base branch from main to release March 5, 2023 11:47
Jupi007
Jupi007 approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpnurmi jpnurmi merged commit 9defcfc into ubuntu:release Mar 5, 2023
@jpnurmi jpnurmi deleted the md-portrait-hero branch March 5, 2023 11:55
@jpnurmi jpnurmi mentioned this pull request Mar 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpnurmi @Jupi007