Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check/Radio/Switch/Button/ListTile: allow customizing mouse cursor #648

Merged
merged 2 commits into from Mar 5, 2023
Merged

Check/Radio/Switch/Button/ListTile: allow customizing mouse cursor #648

merged 2 commits into from Mar 5, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Mar 4, 2023

@jpnurmi jpnurmi requested a review from Jupi007 March 5, 2023 07:50
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to looks good :)
But can you also add the mouseCursor property to checkbox/radio/switch/togglable theme classes?

Edit: I suppose you also plan a PR to change the default cursor?

@jpnurmi
Copy link
Member Author

jpnurmi commented Mar 5, 2023

But can you also add the mouseCursor property to checkbox/radio/switch/togglable theme classes?

Thanks, done!

Edit: I suppose you also plan a PR to change the default cursor?

It's a different discussion but let's start by making them customizable from the outside, at least. :)

I used to feel pretty strong against the hand cursors which is why I spent so much time contributing changes to Flutter to make it themable. The problem is that there are a) many legacy widgets that are missing themes altogether or cannot be made themable without breaking things and b) there are new widgets coming up in every release that are missing themable mouse cursors. As a result, you may end up with a strange mix where some widgets have hand and some basic cursors, and you might have to finish it off by applying some hacks on the app side. Therefore it might be hard to make it the default until Flutter offers a clean way to change the clickable cursor everywhere.

Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpnurmi jpnurmi merged commit a160a96 into ubuntu:main Mar 5, 2023
@jpnurmi jpnurmi deleted the toggle-button-cursor branch March 5, 2023 11:36
@Jupi007
Copy link
Member

Jupi007 commented Mar 5, 2023

I understand.
But to be very honest, now I pretty much like the usage of the pointer cursor in clickable area 😅
It adds an additional semantic information.

@jpnurmi jpnurmi mentioned this pull request Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants