Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YaruCheck/Radio/SwitchButton: add hover & press effects #663

Merged
merged 2 commits into from Mar 6, 2023
Merged

YaruCheck/Radio/SwitchButton: add hover & press effects #663

merged 2 commits into from Mar 6, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Mar 6, 2023

Add a hover effect for the indicator when hovering over the label to highlight the interactive nature of the label.

This becomes more important if the web-oriented pointing finger mouse cursor is changed to a more desktop'ish "basic" mouse cursor.

YaruCheckButton

Screencast.from.2023-03-06.11-09-53.webm

YaruRadioButton

Screencast.from.2023-03-06.11-10-25.webm

YaruSwitchButton

Screencast.from.2023-03-06.11-10-38.webm

Close: #659
Ref: canonical/ubuntu-desktop-installer#1532

Add hover effect for the indicator when hovering the label to highlight
the interactive nature of the label.

This becomes more important if the web-orientend pointing finger mouse
cursor is changed to a more desktop'ish "basic" mouse cursor.

Close: #659
@jpnurmi jpnurmi requested a review from Jupi007 March 6, 2023 12:14
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Would it be possible to also add the active effect?

@jpnurmi
Copy link
Member Author

jpnurmi commented Mar 6, 2023

Would it be possible to also add the active effect?

Ha, thank you for this! Really cool! It didn't even come to my mind because I was so focused on providing a replacement for the cursor. :D

Screencast.from.2023-03-06.13-52-33.webm

@jpnurmi jpnurmi changed the title YaruCheck/Radio/SwitchButton: add hover highlight YaruCheck/Radio/SwitchButton: add hover & press effects Mar 6, 2023
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks very much 👍

@jpnurmi jpnurmi merged commit 1dd727a into ubuntu:main Mar 6, 2023
@jpnurmi jpnurmi deleted the toggle-button-hover branch March 6, 2023 13:10
@jpnurmi jpnurmi mentioned this pull request Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check/Radio/SwitchButton hover highlight
2 participants