Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve YaruPageIndicator #666

Merged
merged 4 commits into from Mar 9, 2023
Merged

Improve YaruPageIndicator #666

merged 4 commits into from Mar 9, 2023

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Mar 9, 2023 •
edited

No design change.

This PR allows various customization options, like:

  • Change items size ;
  • Use a custom item widget ;
  • Use various layout spacing delegates ;
  • Change the text indicator text style ;
  • Use a custom text widget.

See also canonical/ubuntu-desktop-installer#1348

Capture.video.du.2023-03-09.12-34-21.webm

@Jupi007 Jupi007 added this to the 2.2 milestone Mar 9, 2023
@Jupi007 Jupi007 requested a review from jpnurmi March 9, 2023 11:36
jpnurmi
jpnurmi approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and @d-loose even took it for a spin already! 👍

@Jupi007 Jupi007 merged commit 04dc44d into ubuntu:main Mar 9, 2023
@Jupi007 Jupi007 deleted the page_indicator_improvements branch March 9, 2023 13:40
@jpnurmi jpnurmi mentioned this pull request Mar 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnurmi jpnurmi jpnurmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jupi007 @jpnurmi