Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase contrast of togglables unchecked border #667

Merged
merged 3 commits into from Mar 11, 2023
Merged

Increase contrast of togglables unchecked border #667

merged 3 commits into from Mar 11, 2023

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Mar 9, 2023

Before After
Light Capture d’écran du 2023-03-09 14-28-52 Capture d’écran du 2023-03-09 14-26-06
Dark image Capture d’écran du 2023-03-09 14-26-16

CC @elioqoshi @madsrh @jpnurmi

Fixes #665

@Jupi007 Jupi007 added this to the 2.2 milestone Mar 9, 2023
@Jupi007 Jupi007 requested a review from Feichtmeier March 9, 2023 13:31
@madsrh
Copy link
Member

madsrh commented Mar 9, 2023

Small adjustment, but this is better 👍 😄

Feichtmeier
Feichtmeier approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpnurmi
Copy link
Member

jpnurmi commented Mar 11, 2023

@Jupi007 is this ready for merging?

@Jupi007
Copy link
Member Author

Jupi007 commented Mar 11, 2023

Yes, I just wanted your green light, and also @elioqoshi one, but I suppose he agree this, so we can merge :)

@Jupi007 Jupi007 merged commit 970f90f into ubuntu:main Mar 11, 2023
@Jupi007 Jupi007 deleted the Jupi007/issue665 branch March 11, 2023 20:06
@jpnurmi jpnurmi mentioned this pull request Mar 11, 2023
Merged
@elioqoshi
Copy link
Contributor

LGTM, thanks!

@jpnurmi jpnurmi mentioned this pull request Mar 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Feichtmeier Feichtmeier Feichtmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

Increase contrast for checkbox border color
5 participants
@Jupi007 @madsrh @jpnurmi @elioqoshi @Feichtmeier