-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for high contrast theme #682
Conversation
9464c3a
to
be7d6f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @d-loose
LGTM 👍
Thanks, @d-loose! Any concerns with this approach @Feichtmeier and @Jupi007? Unlike my earlier attempt with "barely noticeable" borders, this keeps the normal themes untouched. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it doesn't affect the normal themes it's ok
I just have one note: is adding a border change the size of the window controls? |
that would be bad 🤔 |
@Jupi007 good catch! |
Well, this need to be fixed as it can create unexpected situations :) I see two solution:
Edit: I suppose there is the same problem with |
There is one more option: just make the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @d-loose
I didn't know this strokeAlign
property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bildschirmaufzeichnung.vom.24.03.2023.11.00.04.webm
can't see any visual regression
* bump yaru version * YaruTitleBar: add high contrast border * YaruWindowControl: add high contrast border * YaruMasterTile: add high contrast border * example: enable high contrast themes * fix border alignment * use named constants for `strokeAlign`
Adds high contrast borders to
YaruTitleBar
YaruWindowControl
YaruMasterTile