Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YaruPageIndicator: fix RTL layout #684

Merged
merged 1 commit into from Mar 27, 2023
Merged

YaruPageIndicator: fix RTL layout #684

merged 1 commit into from Mar 27, 2023

Conversation

d-loose
Copy link
Member

@d-loose d-loose commented Mar 24, 2023

Before After
Screenshot from 2023-03-24 16-16-33 image

Close #683

jpnurmi
jpnurmi approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Feichtmeier
Copy link
Member

((( Offtopic: did the uncolored slider always looked like this ? It looks so dark. The knob should also be coloured white I guess in yaru.dart with thumbColor: Colors.white )))

Jupi007
Jupi007 approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm 👍
My bad to not have used start instead of left.

@d-loose d-loose merged commit e9c2612 into ubuntu:release Mar 27, 2023
@jpnurmi jpnurmi mentioned this pull request Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnurmi jpnurmi jpnurmi approved these changes

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d-loose @Feichtmeier @jpnurmi @Jupi007