New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YaruTitleBarTheme: fix border side lerp #688
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM 👍
Oh, @jpnurmi sorry I didn't noticed but this should target |
Hmm, do we actually need the overhead of a secondary branch when there's nothing going on? Maybe we can just branch it off when there's a reason? |
Hmm, yes you're right as there's no breaking nor new feature for now. |
Hmm, and the branch is confusingly a bit behind now, sorry... :D |
Ah, but it should be updated at each new release :D |
Do you prefer a merge or reset? |
Flutter and Qt have release management teams to take care of this. Maybe we should hire some release managers too. 😅 |
When we release a patch version, the
Ahah :D |
ok, |
Great, thanks a lot 🙏 |
The issue is not super well visible in the compressed recordings but basically, the title bar border disappears for a moment whenever the entire app is rebuilt due to language change, and the AnimatedTheme baked into MaterialApp kicks in.
Before
Screencast.from.2023-03-30.13-19-49.webm
After
Screencast.from.2023-03-30.13-20-36.webm