Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YaruTitleBarTheme: fix border side lerp #688

Merged
merged 1 commit into from Mar 30, 2023
Merged

YaruTitleBarTheme: fix border side lerp #688

merged 1 commit into from Mar 30, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Mar 30, 2023

The issue is not super well visible in the compressed recordings but basically, the title bar border disappears for a moment whenever the entire app is rebuilt due to language change, and the AnimatedTheme baked into MaterialApp kicks in.

Before

Screencast.from.2023-03-30.13-19-49.webm

After

Screencast.from.2023-03-30.13-20-36.webm

@jpnurmi jpnurmi requested review from d-loose and Jupi007 March 30, 2023 11:35
Copy link
Member

@d-loose d-loose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM 👍

@jpnurmi jpnurmi merged commit e8f99e5 into ubuntu:main Mar 30, 2023
5 checks passed
@jpnurmi jpnurmi deleted the title-bar-border-lerp branch March 30, 2023 11:57
@Jupi007
Copy link
Member

Jupi007 commented Mar 30, 2023

Oh, @jpnurmi sorry I didn't noticed but this should target release no?

@jpnurmi jpnurmi mentioned this pull request Mar 30, 2023
@jpnurmi
Copy link
Member Author

jpnurmi commented Mar 30, 2023

Hmm, do we actually need the overhead of a secondary branch when there's nothing going on? Maybe we can just branch it off when there's a reason?

@Jupi007
Copy link
Member

Jupi007 commented Mar 30, 2023

Hmm, yes you're right as there's no breaking nor new feature for now.
Sorry to be annoying with this splitting branch idea 😅

@jpnurmi
Copy link
Member Author

jpnurmi commented Mar 30, 2023

Hmm, and the branch is confusingly a bit behind now, sorry... :D

@Jupi007
Copy link
Member

Jupi007 commented Mar 30, 2023

Ah, but it should be updated at each new release :D

@jpnurmi
Copy link
Member Author

jpnurmi commented Mar 30, 2023

Do you prefer a merge or reset?

@jpnurmi
Copy link
Member Author

jpnurmi commented Mar 30, 2023

Flutter and Qt have release management teams to take care of this. Maybe we should hire some release managers too. 😅

@Jupi007
Copy link
Member

Jupi007 commented Mar 30, 2023

When we release a patch version, the release branch should be merged inside main to import fixes.
But once a minor/major one is published, I think we should rebase the release on latest main, instead of doing a merge back 🤔

The Flutter team has a release management team to take care of this. Maybe we should hire some release managers too. sweat_smile

Ahah :D

@jpnurmi
Copy link
Member Author

jpnurmi commented Mar 30, 2023

ok, release is now in sync with main :)

@Jupi007
Copy link
Member

Jupi007 commented Mar 30, 2023

Great, thanks a lot 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants