Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass available width to YaruMasterDetailBuilder #708

Merged
merged 3 commits into from Jun 18, 2023
Merged

Pass available width to YaruMasterDetailBuilder #708

merged 3 commits into from Jun 18, 2023

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Jun 18, 2023

Pass available pane width to YaruMasterDetailBuilder.

This allows the tile builder to be responsive without needing a LayoutBuilder for each tile.

@Jupi007
Copy link
Member Author

Jupi007 commented Jun 18, 2023

Btw, shouldn't YaruMasterDetailBuilder be named YaruMasterDetailTileBuilder?
Imo, it would be more logical.

@Jupi007 Jupi007 merged commit dd56e18 into ubuntu:main Jun 18, 2023
5 checks passed
@Jupi007 Jupi007 deleted the master-detail-builder-available-width branch June 18, 2023 16:23
@Jupi007 Jupi007 mentioned this pull request Jun 18, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jun 29, 2023
Merged
@jpnurmi jpnurmi mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Feichtmeier Feichtmeier Feichtmeier approved these changes

@jpnurmi jpnurmi Awaiting requested review from jpnurmi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jupi007 @Feichtmeier