New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a stack option to YaruChoiceChipBar #714
Conversation
c878d8c
to
fa9b4f8
Compare
Is it normal that the |
I guess |
ah! ok :) |
fa9b4f8
to
b7f770d
Compare
b7f770d
to
504bcb1
Compare
This look better 👍 I just have a few note:
|
Bildschirmaufnahme.2023-06-22.um.12.40.40.movClip was a good idea! |
Why is it not working? 🤔 |
No idea 🤷 if (_enableGoPreviousButton)
AnimatedContainer(
duration: const Duration(seconds: 5),
curve: Curves.bounceInOut,
child: Positioned(
left: 0,
child: goPreviousButton,
),
), no animation 🤷 |
You need to use AnimatedOpacity(
opacity: _enableGoPreviousButton ? 1.0 : 0.0,
duration: const Duration(seconds: 5),
curve: Curves.bounceInOut,
child: Positioned(
left: 0,
child: goPreviousButton,
),
), |
the other way round but now it works thanks! Bildschirmaufnahme.2023-06-22.um.13.07.17.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Eventually I could add the option to parameterize the radius of the buttons and the chips because this may look better if everything was completely round |
@jpnurmi okay if I merge or anything you want to see changed in the design or code? |
please go ahead, no need to wait for me |
This introduces a third option "stack" for the choice chip bar.
Bildschirmaufnahme.2023-06-22.um.11.34.18.mov
Since it changes the parameters of the widget I thought "feat!" was correct ❓