Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve YaruChipChoice parameters #716

Merged
merged 1 commit into from Jun 23, 2023
Merged

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Jun 22, 2023

@Jupi007 @jpnurmi

What would you prefer as the default radius?

This:
grafik

or that:
grafik

@Feichtmeier Feichtmeier marked this pull request as ready for review June 22, 2023 17:29
@Jupi007
Copy link
Member

Jupi007 commented Jun 22, 2023

I prefer the full rounded one.

@Feichtmeier Feichtmeier force-pushed the para_chip_radius branch 2 times, most recently from 5f2342c to 1fb37c9 Compare June 22, 2023 17:35
@Feichtmeier Feichtmeier changed the title feat: parameterize YaruChipChoice more feat: improve YaruChipChoice parameters Jun 22, 2023
@Feichtmeier
Copy link
Member Author

Feichtmeier commented Jun 23, 2023

Okay :) me too, honestly so let's go with this

grafik

Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Feichtmeier Feichtmeier merged commit d92074d into main Jun 23, 2023
5 checks passed
@Feichtmeier Feichtmeier deleted the para_chip_radius branch June 23, 2023 09:09
@github-actions github-actions bot mentioned this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants