feat: add progress indicator themes #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feichtmeier
approved these changes
Jun 25, 2023
|
Thanks, will you release a new version? :) |
|
Yes, I need one to include these changes to the installer. |
|
Oh right, I only set up release-please for yaru.dart so far. I see there are some non-conventional commits that haven't been released yet so it might be good to manually release the next version and setup the release-please for this repo after that. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more theming possibilities to our progress indicators.
No breaking change in the API, but I deprecated a property of
YaruLinearProgressIndicator, and I added a visible track in indeterminate mode.I also reorganized and unified the code lines.
Related to canonical/ubuntu-desktop-installer#1464
Closes #641
Before:
Capture.video.du.2023-06-24.13-43-51.webm
Capture.video.du.2023-06-24.13-44-09.webm
After:
Capture.video.du.2023-06-24.13-26-23.webm
Capture.video.du.2023-06-24.13-39-43.webm