fix(YaruMasterTile): let onTap override scope ontap

[Feichtmeier]

This adds a parameter to disable looking up the YaruMasterTileScope for tiles added to the list inside YMD that should not open a page.

Is this the correct approach @jpnurmi ?

Use case: 1 tile inside the list should open a dialog and not select/load a page

Closes #718

[jpnurmi]

What's the problem you're trying to solve? YaruMasterTileScope.maybeOf() returns null if it's not wrapped into a scope.

[Feichtmeier]

I think you commented 2 secs before I updated the PR desciption :P

This is the use case, X tiles inside the list should not open a page but just onTap:()=> doSomething()

Bildschirmaufzeichnung.vom.2023-07-27.13-41-28.webm

[jpnurmi]

What if we'd allow YaruMasterTile.onTap() "override" the scope i.e. if you specify your own onTap handler then the scope handler won't be called?

diff --git a/lib/src/widgets/master_detail/yaru_master_tile.dart b/lib/src/widgets/master_detail/yaru_master_tile.dart
index f655985..5ba8a32 100644
--- a/lib/src/widgets/master_detail/yaru_master_tile.dart
+++ b/lib/src/widgets/master_detail/yaru_master_tile.dart
@@ -76,8 +76,11 @@ class YaruMasterTile extends StatelessWidget {
           trailing: trailing,
           selected: isSelected,
           onTap: () {
-            scope?.onTap();
-            onTap?.call();
+            if (onTap != null) {
+              onTap!.call();
+            } else {
+              scope?.onTap();
+            }
           },
         ),
       ),

[Feichtmeier]

What if we'd allow YaruMasterTile.onTap() "override" the scope i.e. if you specify your own onTap handler then the scope handler won't be called?

diff --git a/lib/src/widgets/master_detail/yaru_master_tile.dart b/lib/src/widgets/master_detail/yaru_master_tile.dart
index f655985..5ba8a32 100644
--- a/lib/src/widgets/master_detail/yaru_master_tile.dart
+++ b/lib/src/widgets/master_detail/yaru_master_tile.dart
@@ -76,8 +76,11 @@ class YaruMasterTile extends StatelessWidget {
           trailing: trailing,
           selected: isSelected,
           onTap: () {
-            scope?.onTap();
-            onTap?.call();
+            if (onTap != null) {
+              onTap!.call();
+            } else {
+              scope?.onTap();
+            }
           },
         ),
       ),

yeah that would be even better, that was funnily what I assumed would happen when you override ontap 😄

this would also fix #718 btw

[jpnurmi]

LGTM 👍