Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add the missing optional icon parameters #740

Merged
merged 1 commit into from Jul 29, 2023
Merged

fix: add the missing optional icon parameters #740

merged 1 commit into from Jul 29, 2023

Conversation

Feichtmeier
Copy link
Member

Fixes #739

@Feichtmeier Feichtmeier requested a review from Jupi007 July 29, 2023 16:16
@Feichtmeier Feichtmeier merged commit 47d3357 into main Jul 29, 2023
7 checks passed
@Feichtmeier Feichtmeier deleted the Feichtmeier/issue739 branch July 29, 2023 16:18
@github-actions github-actions bot mentioned this pull request Jul 29, 2023
Merged
@Feichtmeier
Copy link
Member Author

@jpnurmi any veto for setting the branch protection rule "require 1 approval before merging"?

Jupi007
Jupi007 approved these changes Jul 29, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Jupi007
Copy link
Member

Jupi007 commented Jul 29, 2023

Shouldn't we also add the icon properties to the theme classes ?

@Feichtmeier
Copy link
Member Author

Shouldn't we also add the icon properties to the theme classes ?

if you have material themes as blueprint no
there is no material theme that presets a prop to a certain Widget
only things like themes, sizes and colors

@Jupi007
Copy link
Member

Jupi007 commented Jul 29, 2023

if you have material themes as blueprint no
there is no material theme that presets a prop to a certain Widget
only things like themes, sizes and colors

Indeed, you're right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add the missing optional icon parameters
2 participants
@Feichtmeier @Jupi007