Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: relax yaru_icons.dart version constraint #743

Closed
wants to merge 1 commit into from

Conversation

Feichtmeier
Copy link
Member

Fixes #742

@jpnurmi
Copy link
Member

jpnurmi commented Jul 31, 2023

Hmm, pub.dev seems to throw a warning :(

Validating package...
Package validation found the following potential issue:

  • Your dependency on "yaru_icons" should have an upper bound. For example:

    dependencies:
    yaru_icons: ^1.0.0

    Without an upper bound, you're promising to support all future versions of yaru_icons.

Package has 1 warning.

@@ -12,7 +12,7 @@ dependencies:
flutter:
sdk: flutter
yaru: ^0.9.0
yaru_icons: ^1.0.0
yaru_icons: ">=1.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, i didn't realize pub.dev being so cranky about this. what about ">=1.0.0 <3.0.0" to make pub.dev happy?

@jpnurmi jpnurmi closed this in #747 Aug 7, 2023
auto-merge was automatically disabled August 7, 2023 10:07

Pull request was closed

@Jupi007 Jupi007 deleted the Feichtmeier/issue742 branch October 19, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

relax yaru_icons.dart version constraint
2 participants