Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve YaruNavigationRailItem #756

Merged
merged 2 commits into from Aug 11, 2023

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Aug 11, 2023

Capture.video.du.2023-08-11.14-07-59.webm
  • Add extendedSelectedIndicator option, which wrap the icon and the label into the selected background indicator ; Capture d’écran du 2023-08-11 13-43-00 Capture d’écran du 2023-08-11 13-43-31
  • Add borderRadius option, to control the selected background indicator border radius. Capture d’écran du 2023-08-11 13-42-28

Fixes #753

- Add `extendedSelectedIndicator` option, which wrap the icon and the label into the selected background indicator ;
- Add `borderRadius` option, to control the selected background indicator border radius.

Fixes ubuntu#753
@Feichtmeier Feichtmeier enabled auto-merge (squash) August 11, 2023 12:10
Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!
I really think about using this layout in musicpod because I think the master layout is not very useful in small windows

@Feichtmeier Feichtmeier merged commit 967903f into ubuntu:main Aug 11, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Aug 11, 2023
@Jupi007 Jupi007 deleted the Jupi007/issue753 branch August 11, 2023 12:14
@Feichtmeier
Copy link
Member

reminder for me to use this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YaruNavigationRailItem: add an option to make selection span icon + label
2 participants