Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: adapt to yaru compact sizes #763

Merged
merged 5 commits into from Aug 15, 2023
Merged

feat!: adapt to yaru compact sizes #763

merged 5 commits into from Aug 15, 2023

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Aug 15, 2023 •
edited

WIP until we have yaru 1.0.0 for pubspec

  • 34 pixel height icons
  • 20 is the default icon size now which affects also listtiles and buttons ofc

See #383

@Jupi007 should we export yaru.dart constants instead and use those? or do we want to play safe and just make sure we sync them?

@Feichtmeier Feichtmeier marked this pull request as draft August 15, 2023 15:06
@Jupi007
Copy link
Member

Jupi007 commented Aug 15, 2023

@Jupi007 should we export yaru.dart constants instead and use those? or do we want to play safe and just make sure we sync them?

We can export a restricted part of constants in a public_constants.dart file.

@Feichtmeier
Copy link
Member Author

I don't mind 😄 what would you prefer

@Jupi007
Copy link
Member

Jupi007 commented Aug 15, 2023

I would prefer to use constants from yaru.dart :)
But let's not export everything.

@Feichtmeier
Copy link
Member Author

snapshot, this already looks like a very big improvement to me
grafik

@Feichtmeier Feichtmeier marked this pull request as ready for review August 15, 2023 17:10
Jupi007
Jupi007 approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Feichtmeier Feichtmeier merged commit aeb809a into main Aug 15, 2023
7 checks passed
@Feichtmeier Feichtmeier deleted the adapt_to_compact_yaru_sizes branch August 15, 2023 17:27
@github-actions github-actions bot mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Feichtmeier @Jupi007