Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add YaruTabBar #781

Merged
merged 5 commits into from Sep 23, 2023
Merged

feat: add YaruTabBar #781

merged 5 commits into from Sep 23, 2023

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Sep 22, 2023 •
edited

Aufzeichnung.2023-09-22.115952.mp4

@Jupi007 which parameters should we expose?

Jupi007
Jupi007 requested changes Sep 22, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I think that, for now, the only thing that we should expose is the height.

lib/src/widgets/yaru_tab_bar.dart Outdated Show resolved Hide resolved
@Feichtmeier Feichtmeier enabled auto-merge (squash) September 23, 2023 07:49
Jupi007
Jupi007 requested changes Sep 23, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply, I have a last little request.

lib/src/widgets/yaru_tab_bar.dart Outdated Show resolved Hide resolved
Jupi007
Jupi007 approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Feichtmeier Feichtmeier merged commit bc64578 into main Sep 23, 2023
7 checks passed
@Feichtmeier Feichtmeier deleted the yaru_tab_bar branch September 23, 2023 08:21
@github-actions github-actions bot mentioned this pull request Sep 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Feichtmeier @Jupi007