Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: final fix for left pane overflow #793

Merged
merged 1 commit into from Oct 25, 2023

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Oct 24, 2023

After investigate how ListTile compute its height I found that the default vertical padding was too big for the minimal visual density.
Like this the intrinsic height is correct, and the vertical alignment is also fixed.

Before | After

image

Fixes #785

@Jupi007 Jupi007 requested a review from d-loose October 24, 2023 21:33
Copy link
Member

@d-loose d-loose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Jupi007 Jupi007 merged commit 8fa166b into ubuntu:main Oct 25, 2023
7 checks passed
@Jupi007 Jupi007 deleted the Jupi007/issue785-final branch October 25, 2023 07:52
@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overflow in left pane of YaruMasterDetailPage
2 participants