feat(YaruWindowControl): pimp up YaruWindowControl #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Windows platform variant ; - Fix issue with foreground and background properties ; - Improve maximize/minimize animation ; - Improve window controls example page.
Feichtmeier
approved these changes
Nov 15, 2023
Yw! 😊
Okay, great 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windowsplatform variant ;foregroundandbackgroundproperties (wasn't used as expected) ;Peek.15-11-2023.18-53.mp4
The only design change (except the animation) we can notice is the minimize icon in disabled state. The little top right chevron is now toned down as expected. It is now exactly looking like its Gtk counterpart.
@Feichtmeier Should we also add a Mac Os version one day or another?