Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(YaruTitleBar): add golden tests windows variant #801

Merged
merged 2 commits into from Nov 19, 2023
Merged

fix(YaruTitleBar): add golden tests windows variant #801

merged 2 commits into from Nov 19, 2023

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Nov 19, 2023

Add YaruTitleBar windows golden variant.
I also added the missing parameters to the YaruDialogTitleBar constructor.

Part of #798

Feichtmeier
Feichtmeier approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@Jupi007 Jupi007 merged commit e6d02ca into ubuntu:main Nov 19, 2023
7 checks passed
@Jupi007 Jupi007 deleted the windows-titlebar-goldens branch November 19, 2023 22:08
@github-actions github-actions bot mentioned this pull request Nov 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Feichtmeier Feichtmeier Feichtmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jupi007 @Feichtmeier