Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(YaruChoiceChipBar): allow more parameters #828

Merged
merged 1 commit into from Jan 16, 2024

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Jan 16, 2024

This allows to control the border color of the internal chiptheme.
This is needed because the bar includes an internal chiptheme which overwrites the one from Theme.of(context).

This internal chiptheme is needed to align the button radius to the chip radius.

Additionally this also adds options to set the background and selected background colors.

@Feichtmeier Feichtmeier force-pushed the fix(YaruChoiceChipBar)--allow-border-color branch from 98453c3 to ef92b05 Compare January 16, 2024 05:29
@Feichtmeier Feichtmeier changed the title fix(YaruChoiceChipBar): allow border color fix(YaruChoiceChipBar): allow more parameters Jan 16, 2024
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Feichtmeier Feichtmeier merged commit f09fe93 into main Jan 16, 2024
9 checks passed
@Feichtmeier Feichtmeier deleted the fix(YaruChoiceChipBar)--allow-border-color branch January 16, 2024 09:32
@github-actions github-actions bot mentioned this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants