Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IconButton): selected color needs to be different to onSurface #869

Merged
merged 2 commits into from Mar 4, 2024
Merged

fix(IconButton): selected color needs to be different to onSurface #869

merged 2 commits into from Mar 4, 2024

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Mar 4, 2024 •
edited

Fixes #862

This slightly increases also the contrast of the icon colors everywhere, IMO this is a good change, WDYT @Jupi007 ?

@Feichtmeier Feichtmeier requested a review from Jupi007 March 4, 2024 12:22
@Jupi007
Copy link
Member

Jupi007 commented Mar 4, 2024 •
edited

Can you post a screenshot before/after, please? 🙏
I'm currenly not at home, and looking at the golden diff is impossible with the github app.

@Feichtmeier
Copy link
Member Author

Feichtmeier commented Mar 4, 2024 •
edited

sure, sorry. here you go @Jupi007

Before:

Bildschirmaufnahme.2024-03-04.um.14.29.16.mov

After:

Bildschirmaufnahme.2024-03-04.um.14.28.11.mov

Jupi007
Jupi007 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is clearly an improvement 👍

@Feichtmeier Feichtmeier merged commit eb88458 into main Mar 4, 2024
7 of 8 checks passed
@Feichtmeier Feichtmeier deleted the Feichtmeier/issue862 branch March 4, 2024 13:35
@github-actions github-actions bot mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IconButton seleted color needs to be different to onSurface
2 participants
@Feichtmeier @Jupi007