Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(example): add missing icon #879

Merged
merged 1 commit into from Mar 8, 2024
Merged

chore(example): add missing icon #879

merged 1 commit into from Mar 8, 2024

Conversation

Feichtmeier
Copy link
Member

Now all icons are searched with ls -l | grep -v ^l >> icons.txt, so the list is complete. I started manually in apps when realizing that this is no fun.
Eventually the github dart package can be used to get the names automatically, if it can filter out symlinks. Otherwise it is not really a problem with the bash command.

Now all icons are searched with ls -l | grep -v ^l >> icons.txt, so the list is complete. I started manually in apps when realizing that this is no fun.
Eventually the github dart package can be used to get the names automatically, if it can filter out symlinks. Otherwise it is not really a problem with the bash command.
@Feichtmeier Feichtmeier enabled auto-merge (squash) March 8, 2024 13:35
@Feichtmeier Feichtmeier requested a review from Jupi007 March 8, 2024 13:35
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Feichtmeier Feichtmeier merged commit edc1f4c into main Mar 8, 2024
7 checks passed
@Feichtmeier Feichtmeier deleted the missing_icon branch March 8, 2024 18:00
@github-actions github-actions bot mentioned this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants