fix(YaruMasterDetailPage): has too many nested Scaffolds #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs testing on all platforms, as all platforms behave differently with "draw in in the native window" before it can be considered a solution.
Note: in fact no scaffold is needed by default at all, as we only require the next child of materialapp to be a material widget. Scaffold is a very heavy widget with lots of stuff going on there. Even if the "expected" child page of one master element is a Scaffold or a YaruDetailPage, which is a Scaffold with lipstick
The normal layout with YMDP is the following
Fixes #728