Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for qt5ct with qt5-gtk-platformtheme #1357

Open
lwbt opened this issue May 12, 2019 · 8 comments
Open

Add support for qt5ct with qt5-gtk-platformtheme #1357

lwbt opened this issue May 12, 2019 · 8 comments

Comments

@lwbt
Copy link

lwbt commented May 12, 2019

Expected Behavior

QT5 apps like KeepassXC and VLC should render in GTK3 Yaru style instead of Adwaita.

I did some research and found threads where qt5ct with qt5-gtk-platformtheme is recommended: keepassxreboot/keepassxc#1931

Actual Behavior

Only Adwaita is offered in the selection.

https://i.imgur.com/El3r9Gi.png

Steps to Reproduce the Problem

  1. apt install qt5ct qt5-gtk-platformtheme
  2. run and configure qt5ct, for example to use a dark theme variant
  3. run example app with QT_QPA_PLATFORMTHEME="qt5ct" vlc or put it in your .profile file

Specifications

I'm running yaru as it is shipped with 19.04.

Software that presents the issue:

$ apt-cache policy vlc keepassxc qt5ct qt5-gtk-platformtheme yaru-theme-gnome-shell 
vlc:
  Installed: 3.0.6-1
  Candidate: 3.0.6-1
  Version table:
 *** 3.0.6-1 500
        500 http://archive.ubuntu.com/ubuntu disco/universe amd64 Packages
        100 /var/lib/dpkg/status
keepassxc:
  Installed: 2.3.4+dfsg.1-1
  Candidate: 2.3.4+dfsg.1-1
  Version table:
 *** 2.3.4+dfsg.1-1 500
        500 http://archive.ubuntu.com/ubuntu disco/universe amd64 Packages
        100 /var/lib/dpkg/status
qt5ct:
  Installed: 0.37-1build1
  Candidate: 0.37-1build1
  Version table:
 *** 0.37-1build1 500
        500 http://archive.ubuntu.com/ubuntu disco/universe amd64 Packages
        100 /var/lib/dpkg/status
qt5-gtk-platformtheme:
  Installed: 5.12.2+dfsg-4ubuntu1
  Candidate: 5.12.2+dfsg-4ubuntu1
  Version table:
 *** 5.12.2+dfsg-4ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu disco/universe amd64 Packages
        100 /var/lib/dpkg/status
yaru-theme-gnome-shell:
  Installed: 19.04.2
  Candidate: 19.04.2
  Version table:
 *** 19.04.2 500
        500 http://archive.ubuntu.com/ubuntu disco/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu disco/main i386 Packages
        100 /var/lib/dpkg/status
@clobrano
Copy link
Member

Hi @lwbt, thank you for taking time to report this and for the research, awesome!
I wonder how we can add yaru to the list, we might need to reach the maintainers of the project and ask them

@Paz-it
Copy link

Paz-it commented May 12, 2019

Hi @lwbt -From your description it looks like you installed only Yaru-shell theme, correct me if I'm wrong.
IF I'm right you have to install the Gtk part of it that include Gtk3+Gtk2 as well.
When you do :
Try to choose Gtk2 in the menu and run your example line like this :
QT_QPA_PLATFORMTHEME="gtk2" vlc
Is it working for you that way?

@clobrano
Copy link
Member

clobrano commented May 12, 2019 via email

@Paz-it
Copy link

Paz-it commented May 12, 2019

Yaru is installed by default in 19.04, no need to install other pieces manually

That's correct @clobrano , Sorry! I'm still on 18.04 LTS . But all the rest should work as far as I understand.

@Feichtmeier
Copy link
Member

Opened the zip.. isn't this the same as
#1294 ?

@lwbt
Copy link
Author

lwbt commented May 13, 2019

I don't see any relation.

@Feichtmeier
Copy link
Member

Nvm, I should stay away from GitHub before 10:00 xD

@CDrummond
Copy link
Contributor

The Qt5 configuration tool will only show Qt themes. There is an Adwaita Qt theme, which provides Adwaita and Adwiata-Dark for Qt apps - which is why these appear in the list. For Yaru to appear in this list, there would need to be a pure Qt version of Yaru.

I seem to recall that Adwaita-Qt is GPL licenses, as is Kvantum, so not sure Ubuntu can install that - for the same reasons it cannot use Kvantum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants