Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt app, kid3-qt, uses legacy icons "document-*.png" #1621

Closed
Amr-Ibra opened this issue Nov 15, 2019 · 0 comments · Fixed by #1639
Closed

Qt app, kid3-qt, uses legacy icons "document-*.png" #1621

Amr-Ibra opened this issue Nov 15, 2019 · 0 comments · Fixed by #1639
Assignees
Projects

Comments

@Amr-Ibra
Copy link

Amr-Ibra commented Nov 15, 2019

The Qt app, kid3-qt, uses these legacy icons:

  • document-revert.png
  • document-open-recent.png
  • document-import.png
  • document-export.png

However, they are rendered as a normal document icon under Yaru (except for "document-open-recent.png" because it is rendered as legacy "document-open.png").

Qt apps only have a problem with legacy icons starting with "document-*" and all other legacy icons are inherited from Humanity.

Is there a general solution to force Qt apps to choose the closest icon name from Yaru or Humanity?

Should this bug be issued against Qt?

For example, here are two icons in Adwaita:

document-revert.png
grafik

document-revert-rtl.png
grafik

@Feichtmeier Feichtmeier added this to To do in Yaru via automation Nov 15, 2019
@Amr-Ibra Amr-Ibra changed the title Add legacy icons "document-revert.png" and "document-revert-rtl.png" Qt app "kid3-qt" uses legacy icons "document-revert.png", document-import.png", "document-export.png" and "document-open-recent.png" Nov 18, 2019
@Amr-Ibra Amr-Ibra changed the title Qt app "kid3-qt" uses legacy icons "document-revert.png", document-import.png", "document-export.png" and "document-open-recent.png" Qt app "kid3-qt" uses legacy icons "document-*.png" Nov 18, 2019
@Amr-Ibra Amr-Ibra changed the title Qt app "kid3-qt" uses legacy icons "document-*.png" Qt app, kid3-qt, uses legacy icons "document-*.png" Nov 18, 2019
Yaru automation moved this from To do to Done Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Yaru
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants