Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons: document-export, document-import, document-open-recent, document-revert #1639

Merged
merged 2 commits into from
Nov 29, 2019

Conversation

ubuntujaggers
Copy link
Contributor

document-export:

image

document-import:

image

document-open-recent:

image

document-revert:

image

image

Can't seem to take a screenshot when the dropdown menu is open :) but here's an extremely high quality photograph of them on the menu, including ones that aren't visible above:

image

Can't really tell in that picture, but they actually look nice on the menu!

(I note that apps using the icons on menus use the 16px versions so we have to keep those, even though it's annoying that Inkscape uses the first and therefore smallest version it finds.)

Closes #1621

@clobrano
Copy link
Member

Great work @ubuntujaggers!
I only have one doubt. Do you think it's worthwhile enforce the difference between "import" and "export" icons inverting the direction of the red arrow? I was thinking something like the "import" one, but with the arrow red and in the other direction.

@ubuntujaggers
Copy link
Contributor Author

@clobrano can you do a doodle to show?

@Feichtmeier
Copy link
Member

I think he means

_____
->
_____

_____
<-
_____

instead of

_____
-------->
_____

_____
<------
_____

😸

@clobrano
Copy link
Member

I think he means

_____
->
_____

_____
<-
_____

instead of

_____
-------->
_____

_____
<------
_____

awesome design! Yes, I meant that

@ubuntujaggers
Copy link
Contributor Author

Looks a bit revert, undo, go back:

image

Maybe if it wasn't red?

@madsrh
Copy link
Member

madsrh commented Nov 27, 2019

IMHO the red (associated with danger) isn't really fitting for export - it's not that dangerous 😉 Also using red for both export and revert might be confusing.

Would it be better if it was blue? 🤷‍♂ BUT your red arrow is more in line with legacy Humanity icons 🤔

image

@Feichtmeier
Copy link
Member

Now that I see it I agree that reversing the arrow is not a good idea. Indeed it looks like "reverse" / "undo"

@ubuntujaggers
Copy link
Contributor Author

Purple also works...

@Feichtmeier
Copy link
Member

I think semanticly blue makes the most sense as it's some kind of progress
Green for import fits also as it's something new

@clobrano
Copy link
Member

clobrano commented Nov 28, 2019

Looks a bit revert, undo, go back:

Indeed, mine was a bad idea :)
I should've searched the most common export icons first. Original proposal is quite common 👍

@ubuntujaggers
Copy link
Contributor Author

Okay, I'll turn first one blue and push 👍

@ubuntujaggers
Copy link
Contributor Author

This is the original document-export arrow in blue:

image

Change is pushed, so merge if you like 👍

@clobrano
Copy link
Member

Thanks @ubuntujaggers!

@clobrano clobrano merged commit eede9b2 into master Nov 29, 2019
@ubuntujaggers
Copy link
Contributor Author

I get an error message when I try to cherry pick this one for Bionic 🤔

@clobrano
Copy link
Member

can you post it here?

@ubuntujaggers
Copy link
Contributor Author

ubuntujaggers commented Dec 12, 2019

It's all right - Frederik beat me to it as part of #1645 👍

@ubuntujaggers ubuntujaggers deleted the IconTheme_MoreLegacyActions branch March 3, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt app, kid3-qt, uses legacy icons "document-*.png"
4 participants