Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark shell theme no longer selectable in gnome-tweaks #2043

Closed
chrisjbillington opened this issue Mar 6, 2020 · 3 comments · Fixed by #2050
Closed

Dark shell theme no longer selectable in gnome-tweaks #2043

chrisjbillington opened this issue Mar 6, 2020 · 3 comments · Fixed by #2050

Comments

@chrisjbillington
Copy link
Contributor

A few commits ago, the dark shell theme was installed to /usr/share/themes/Yaru-dark/gnome-shell, and now it has moved to /usr/share/gnome-shell/themes/Yaru-dark.

I see that this brings it in line with the light shell theme, which lives in /usr/share/gnome-shell/themes/Yaru, but is symlinked to from /usr/share/themes/Yaru/gnome-shell.

However, The dark shell theme is no longer selectable in gnome-tweaks (at least on gnome 3.34).

Should it get a symlink from /usr/share/themes/Yaru-dark/gnome-shell like the light theme has? Or are things different in gnome 3.36 such that those symlinks are not necessary for the themes to appear in gnome-tweaks (in which case the light theme's symlink can be removed)?

@clobrano
Copy link
Member

clobrano commented Mar 6, 2020

Hi @chrisjbillington,

I noticed this yesterday, the fix should be easy, I'm jus waiting for a feedback from desktop team

@framilano
Copy link

The Yaru-dark entry disappeared even with the Yaru release from January (19.10.5), so it doesn't seem to be related to the latest changes, any idea?

@chrisjbillington
Copy link
Contributor Author

@fra98 for me I saw it in gnome-tweaks until a few commits ago and can pinpoint the cause as the move of the dark shell theme out of /usr/share/themes. However, I'm building from source (well, in the context of an Arch Linux package).

It's possible that for e.g. the Debian packages something could be packaged wrong leading to a similar issue - what OS and packages are you using?

@clobrano thanks! Feel free to close my PR, and if you @ me in the changes I'll test them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants