Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symlink to dark shell theme in /usr/share/themes #2044

Closed

Conversation

chrisjbillington
Copy link
Contributor

Fixes issue #2043

The dark shell theme was moved from /usr/share/themes/Yaru-dark/gnome-shell to
/usr/share/gnome-shell/themes/Yaru-dark.

As with the light shell theme, a symlink should be left in its old location so that it is visible in gnome-tweaks.

The dark shell theme was moved from
/usr/share/themes/Yaru-dark/gnome-shell to
 /usr/share/gnome-shell/themes/Yaru-dark.

As with the light shell theme, a symlink should be left in its old
location so that it is visible in gnome-tweaks.
@Feichtmeier
Copy link
Member

Thanks for the PR
I don't remember what's the deal but I'm sure @3v1n0 had some reason for it. Let's please wait for his reply

@clobrano
Copy link
Member

clobrano commented Mar 6, 2020 via email

@3v1n0
Copy link
Contributor

3v1n0 commented Mar 6, 2020

Mh, couldn't be that I just maybe generate the install dir with a wrong path?

Maybe this can be fixed with meson only changes?
As if we use gresources we can just install everything under /usr/share/gnome-shell/themes/Yaru-dark, at least that was the point. While otherwise it may stay under shell domain.

@clobrano
Copy link
Member

clobrano commented Mar 6, 2020

Indeed, the fix - when not using gresource - is simply to call the install script with Yaru-dark name. I'll push the PR asap

As if we use gresources we can just install everything under /usr/share/gnome-shell/themes/Yaru-dark, at least that was the point. While otherwise it may stay under shell domain.

the alternate directory install under /usr/share/themes/Yaru-dark/gnome-shell is used by User Themes extension, that's why we need it, I don't know if it is still necessary when using gresource

@chrisjbillington
Copy link
Contributor Author

Closing in favour of #2050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants