Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GtkSpinner is blue on destructive buttons #2182

Closed
Feichtmeier opened this issue May 6, 2020 · 2 comments · Fixed by #2187
Closed

GtkSpinner is blue on destructive buttons #2182

Feichtmeier opened this issue May 6, 2020 · 2 comments · Fixed by #2187
Assignees
@Feichtmeier
Labels
Area: gtk3
Projects
Yaru

Comments

@Feichtmeier
Copy link
Member

grafik
This is simplescan

Imo it should be white
@Feichtmeier Feichtmeier added this to Backlog in Yaru via automation May 6, 2020
@Feichtmeier Feichtmeier self-assigned this May 6, 2020
@clobrano
Copy link
Member

clobrano commented May 8, 2020

It makes sense. I wonder though if it's too hard to add a minimal dark border also, so that if it appears over white surfaces it'll be still visible

Feichtmeier added a commit that referenced this issue May 8, 2020
@Feichtmeier
Special spinners in case destructive, suggested action buttons
8ffea51 
Bright blue spinners on bright green/red buttons looks weird. This can happen in simple-scan.
Closes #2182
@Feichtmeier Feichtmeier mentioned this issue May 8, 2020
Merged
@Feichtmeier
Copy link
Member Author

I would rather special case this only for those situations. Please see the PR

Yaru automation moved this from Backlog to Done in 20.04 May 25, 2020
Feichtmeier added a commit that referenced this issue May 25, 2020
@Feichtmeier
Special case spinners in destructive, suggested action buttons (#2187)
073e786 
* Special case spinners in destructive, suggested action buttons

Bright blue spinners on bright green/red buttons looks weird. This can happen in simple-scan.
Closes #2182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Feichtmeier Feichtmeier

Labels
Area: gtk3
Projects
Yaru
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Special case spinners in destructive, suggested action buttons ubuntu/yaru
2 participants
@clobrano @Feichtmeier