Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: remove the mixed theme from Yaru #2913

Closed
Feichtmeier opened this issue Jun 15, 2021 · 5 comments · Fixed by #2922
Closed

Proposal: remove the mixed theme from Yaru #2913

Feichtmeier opened this issue Jun 15, 2021 · 5 comments · Fixed by #2922

Comments

@Feichtmeier
Copy link
Member

Feichtmeier commented Jun 15, 2021

Gtk3 and Gtk4 both do not support having different background/text colors for headerbar than in the rest of the window. This means that to have bug free applications, the headerbar needs to have the same background and text "luminescence" as the rest of the window. The technical reason for this is, that the only "api" available for theming in gtk, public-color.scss, does not support headerbar colors.

Examples:

The only solution to fix these problems is to "only" have yaru-light and yaru-dark themes - which is the defacto standard on other operating systems.

Personal note: I think theming should only be made with the tools available - if the platform does not support some design, it should not be forced.

Relevant discussion: #2677 point 6

@Feichtmeier Feichtmeier added this to Backlog in Yaru via automation Jun 15, 2021
@Feichtmeier Feichtmeier moved this from Backlog to To Do - 21.10 in Yaru Jun 15, 2021
@madsrh
Copy link
Member

madsrh commented Jun 17, 2021

Here's another example from Firefox: (issue #2918 )

image

@Initu-Castilhos
Copy link

In case Yaru-light will be renamed to Yaru?

@Feichtmeier
Copy link
Member Author

Yes, we will probably stick to "yaru" and "yaru-dark" then ⚪ / ⚫

@Benni3-1415
Copy link
Contributor

Benni3-1415 commented Jun 19, 2021

I like the mixed theme very much.

One idea to keep it alive:

idea

The lighter shade doesn't look as good as before, but the widgets could stay in the light theme.

@elioqoshi
Copy link
Contributor

Just to be explicit: I went over this with the Brand and Visual team at Canonical and we agree that this is the best way to move forward. We would also aim to be closer in the loop with stylistic decisions for the next release since we are doing a rebranding where it would be beneficial to be more up-to-date with progress

Yaru automation moved this from To Do - 21.10 to Done Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Yaru
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants