Firefox tabs appear incorrectly in the mixed theme

[madsrh]

Because we're using a dark headerbar in an otherwise light theme, Firefox is styling the tabs incorrectly. The two issues are:

• a white background for the selected/active tab
• icons not being inverted (see the Github icon below)

[hwittenborn]

I'm on Ubuntu 20.04, but I don't even have the GitHub icon working correctly on the full dark theme:

I'm in Google Chrome if it helps at all.

Is it just a bug with the 20.04 release of Yaru or something?

[madsrh]

Is it just a bug with the 20.04 release of Yaru or something?

This is a bug in Chrome not supporting dark themes. There's nothing we can do here.

[Benni3-1415]

icons not being inverted (see the Github icon below)

The browser does not invert the icon, Github detects the color scheme with prefers-color-scheme (in the mixed theme light) and then sets the icon (in this case dark).
This error has been also existing on Windows until Firefox 89 came out and the title-bar color changed from dark blue to white.

[Feichtmeier]

Fixed with #2922

[fallenguru]

The selected tab being light is a feature, not a bug ... It's now much harder to see which tab is active.
I'll give you the not-inverted website icons, but those are a very minor annoyance compared to the fact that it's now very hard to tell the title bar apart from the window contents in all applications. Contrast is a good thing, people!