Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace page-indicator icons with SCSS /copied from upstream shell theme #1205

Merged
merged 3 commits into from
Feb 23, 2019

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Feb 22, 2019

@madsrh @clobrano please test this on your bionic snap installations, if it works there we are golden. If not we need an extra branch for disco or for bionic

Eventually closes #1204

Before:
broken

After:
fix

Todo IF it works for bionic

  • remove the unused assets

@didrocks
Copy link
Member

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr1205.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr1205 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

In normal state, border color with alpha 0.4 is very dark.
For some reasons, changing it to 0.5 makes a huge difference.
@didrocks
Copy link
Member

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr1205.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr1205 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

@Feichtmeier
Copy link
Member Author

18.04, testing this snap
image

Works! 🎉 🎉

@clobrano clobrano merged commit c106be2 into master Feb 23, 2019
@Feichtmeier Feichtmeier deleted the ShellTheme_page_indicator branch February 25, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GNOME Shell app grid page indicator not visible
3 participants