Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dash to dock padding fixes #2186

Merged
merged 2 commits into from May 8, 2020
Merged

Dash to dock padding fixes #2186

merged 2 commits into from May 8, 2020

Conversation

3v1n0
Copy link
Contributor

@3v1n0 3v1n0 commented May 7, 2020

And sync settings from upstream stylesheet.

3v1n0 added 2 commits May 8, 2020 00:29
@3v1n0
gnome-shell, dock: Remove the top/bottom padding
42e2c41 
Add padding only to the scroll view, not to the whole dock or it won't make
the first/last icons clickable when the mouse is at screen edges.

LP: #1873321
@3v1n0
gnome-shell, dock: Sync style parameters with upstream
fda2ce7
@3v1n0 3v1n0 merged commit 1db2d1b into ubuntu:master May 8, 2020
@Feichtmeier
Copy link
Member

@3v1n0 odd place to ask, but since it looks to be that you have became one of the main dash to dock contributors I thought I could ask:

is there any way to reduce the yaru dock styling to a minumum?
I think this idea how we use this dock.scss file comes from the very beginning of the project.
I often thought that it was weird to paste in the whole style sheet there and that the file is a little bit confusing because you also have the dash styling which comes from upstream (like 95% of our styling)
In the end - I think - our changes break down to two changes:

  • green notification badges
  • different padding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@3v1n0 @Feichtmeier